shutdown works

src/discovery.rs

@@ -29,13 +29,12 @@ impl JoecalState {
         println!("Listening on multicast addr: {}", config.multicast_addr);
 
         let mut timeout = tokio::time::interval(Duration::from_secs(5));
-        timeout.tick().await;
 
         loop {
             tokio::select! {
                 _ = timeout.tick() => {
-                    if let Ok(state) = self.running_state.try_lock()
+                    let rstate = self.running_state.lock().await;
-                        && *state == RunningState::Stopping
+                    if *rstate == RunningState::Stopping
                     {
                         break;
                     }

src/http_server.rs

@@ -59,6 +59,5 @@ impl JoecalState {
 }
 
 async fn shutdown(mut rx: mpsc::Receiver<()>) {
-    println!("shutting down");
     rx.recv().await.unwrap_or_default()
 }

src/lib.rs

@@ -7,7 +7,8 @@ pub mod transfer;
 use std::{
     collections::HashMap,
     net::{Ipv4Addr, SocketAddr, SocketAddrV4},
-    sync::Arc,
+    sync::{Arc, OnceLock},
+    time::Duration,
 };
 
 use models::Device;
@@ -24,6 +25,8 @@ pub const MULTICAST_IP: Ipv4Addr = Ipv4Addr::new(224, 0, 0, 167);
 pub const LISTENING_SOCKET_ADDR: SocketAddrV4 =
     SocketAddrV4::new(Ipv4Addr::from_bits(0), DEFAULT_PORT);
 
+type ShutdownSender = mpsc::Sender<()>;
+
 /// Contains the main network and application state for an application session.
 #[derive(Clone)]
 pub struct JoecalState {
@@ -33,7 +36,7 @@ pub struct JoecalState {
     pub running_state: Arc<Mutex<RunningState>>,
     pub socket: Arc<UdpSocket>,
     pub client: reqwest::Client,
-    stop_tx: std::sync::OnceLock<mpsc::Sender<()>>,
+    stop_tx: OnceLock<ShutdownSender>,
 }
 
 impl JoecalState {
@@ -61,10 +64,10 @@ impl JoecalState {
         let state = self.clone();
         let konfig = config.clone();
         let server_handle = {
-            let (tx, rx) = mpsc::channel(1);
+            let (tx, shutdown_rx) = mpsc::channel(1);
             self.stop_tx.get_or_init(|| tx);
             tokio::spawn(async move {
-                if let Err(e) = state.start_http_server(rx, &konfig).await {
+                if let Err(e) = state.start_http_server(shutdown_rx, &konfig).await {
                     eprintln!("HTTP server error: {e}");
                 }
             })
@@ -84,12 +87,10 @@ impl JoecalState {
         let announcement_handle = {
             tokio::spawn(async move {
                 loop {
-                    if let Ok(lock) = state.running_state.try_lock()
+                    let rstate = state.running_state.lock().await;
-                        && *lock == RunningState::Stopping
+                    if *rstate == RunningState::Stopping {
-                    {
                         break;
                     }
-
                     if let Err(e) = state.announce(None, &config).await {
                         eprintln!("Announcement error: {e}");
                     }
@@ -103,18 +104,19 @@ impl JoecalState {
 
     pub async fn stop(&self) {
         loop {
-            if let Ok(mut lock) = self.running_state.try_lock() {
+            let mut rstate = self.running_state.lock().await;
-                *lock = RunningState::Stopping;
+            *rstate = RunningState::Stopping;
-                if self
+            if self
-                    .stop_tx
+                .stop_tx
-                    .get()
+                .get()
-                    .expect("Could not get stop signal transmitter")
+                .expect("Could not get stop signal transmitter")
-                    .send(())
+                .send(())
-                    .await
+                .await
-                    .is_ok()
+                .is_ok()
-                {
+            {
-                    break;
+                break;
-                }
+            } else {
+                tokio::time::sleep(Duration::from_millis(777)).await;
             }
         }
     }
@@ -128,8 +130,6 @@ impl JoecalState {
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum RunningState {
     Running,
-    Sending,
-    Receiving,
     Stopping,
 }
 

src/main.rs

@@ -46,7 +46,7 @@ async fn main() -> error::Result<()> {
     let config = Config::default();
     let (h1, h2, h3) = state.start(&config).await.unwrap();
 
-    let mut app = App::new(state.clone());
+    let mut app = App::new(state.clone()).await;
     let mut terminal = ratatui::init();
     let result = app.run(&mut terminal).await;
     ratatui::restore();
@@ -58,20 +58,24 @@ async fn main() -> error::Result<()> {
 
 struct App {
     state: JoecalState,
+    rstate: RunningState,
 }
 
 impl App {
-    pub fn new(state: JoecalState) -> Self {
+    pub async fn new(state: JoecalState) -> Self {
-        App { state }
+        App {
+            state: state.clone(),
+            rstate: *state.running_state.lock().await,
+        }
     }
 
     pub async fn run(&mut self, terminal: &mut DefaultTerminal) -> io::Result<()> {
         loop {
             terminal.draw(|frame| self.draw(frame))?;
             self.handle_events().await?;
-            if let Ok(lock) = self.state.running_state.try_lock()
+            let rstate = self.state.running_state.lock().await;
-                && *lock == RunningState::Stopping
+            self.rstate = *rstate;
-            {
+            if *rstate == RunningState::Stopping {
                 break;
             }
         }
@@ -111,7 +115,7 @@ impl App {
 
 impl Widget for &App {
     fn render(self, area: Rect, buf: &mut Buffer) {
-        let title = Line::from(" Counter App Tutorial ".bold());
+        let title = Line::from(" Joecalsend ".bold());
         let instructions = Line::from(vec![
             " Send ".into(),
             "<S>".blue().bold(),
@@ -127,12 +131,7 @@ impl Widget for &App {
             .title_bottom(instructions.centered())
             .border_set(border::THICK);
 
-        let rs = self
+        let rs = format!("{:?}", self.rstate);
-            .state
-            .running_state
-            .try_lock()
-            .map(|s| format!("{s:?}"))
-            .unwrap_or("Just a moment...".into());
         let state_text = Text::from(vec![Line::from(vec!["runstate: ".into(), rs.yellow()])]);
 
         Paragraph::new(state_text)