multithreaded update

src/lib.rs

@@ -1,11 +1,9 @@
 use std::{
-    sync::{
+    sync::{Arc, RwLock},
-        atomic::{AtomicUsize, Ordering::Relaxed},
-        Arc, RwLock,
-    },
     thread,
 };
 
+#[derive(Debug, Default, Clone, Copy, PartialEq, PartialOrd)]
 pub struct Point2d {
     pub x: f64,
     pub y: f64,
@@ -13,8 +11,8 @@ pub struct Point2d {
 
 #[derive(Debug, Default, Clone, Copy)]
 pub struct PVal {
-    pub point: usize,
+    point_index: usize,
-    pub val: f64,
+    val: f64,
 }
 
 impl PartialEq for PVal {
@@ -41,21 +39,25 @@ impl Ord for PVal {
 
 impl PVal {
     pub fn new(point: usize, val: f64) -> Self {
-        Self { point, val }
+        Self {
+            point_index: point,
+            val,
+        }
     }
 
     pub fn point_index(&self) -> usize {
-        self.point
+        self.point_index
     }
 
-    // pub fn val(&self) -> f64 {
+    pub fn val(&self) -> f64 {
-    //     f64::from_bits(self.val)
+        self.val
-    // }
+    }
 }
 
+#[derive(Debug, Default, Clone)]
 pub struct Spindex2d {
-    pub xpoints: Arc<Vec<AtomicUsize>>,
+    pub xpoints: Arc<RwLock<Vec<usize>>>,
-    pub ypoints: Arc<Vec<AtomicUsize>>,
+    pub ypoints: Arc<RwLock<Vec<usize>>>,
     pub xs: Arc<RwLock<Vec<PVal>>>,
     pub ys: Arc<RwLock<Vec<PVal>>>,
 }
@@ -63,28 +65,32 @@ pub struct Spindex2d {
 impl Spindex2d {
     pub fn new(points: &[Point2d]) -> Self {
         let mut xpoints = Vec::with_capacity(points.len());
-        let mut ypoints = Vec::with_capacity(points.len());
         let mut xs = Vec::with_capacity(points.len());
-        let mut ys = Vec::with_capacity(points.len());
-        for (i, point) in points.iter().enumerate() {
-            let x = PVal {
-                point: i,
-                val: point.x,
-            };
-            xs.push(x);
-            let y = PVal {
-                point: i,
-                val: point.y,
-            };
-            ys.push(y);
 
-            xpoints.push(AtomicUsize::new(i));
+        let mut ypoints = Vec::with_capacity(points.len());
-            ypoints.push(AtomicUsize::new(i));
+        let mut ys = Vec::with_capacity(points.len());
+
+        thread::scope(|s| {
+            s.spawn(|| {
+                for (i, point) in points.iter().enumerate() {
+                    let x = PVal::new(i, point.x);
+                    xs.push(x);
+                    xpoints.push(i);
                 }
+            });
+
+            s.spawn(|| {
+                for (i, point) in points.iter().enumerate() {
+                    let y = PVal::new(i, point.y);
+                    ys.push(y);
+                    ypoints.push(i);
+                }
+            });
+        });
 
         let index = Self {
-            xpoints: xpoints.into(),
+            xpoints: Arc::new(RwLock::new(xpoints)),
-            ypoints: ypoints.into(),
+            ypoints: Arc::new(RwLock::new(ypoints)),
             xs: Arc::new(RwLock::new(xs)),
             ys: Arc::new(RwLock::new(ys)),
         };
@@ -98,21 +104,30 @@ impl Spindex2d {
     /// when constructing this index. May panic if the updated points argument is longer than the
     /// original points.
     pub fn update(&self, points: &[Point2d]) {
-        {
+        thread::scope(|s| {
+            s.spawn(|| {
                 let mut xs = self.xs.write().unwrap();
-            let mut ys = self.ys.write().unwrap();
+                let xpoints = self.xpoints.read().unwrap();
-            for (i, point) in points.iter().enumerate() {
-                let xi = self.xpoints[i].load(Relaxed);
-                let yi = self.ypoints[i].load(Relaxed);
-                let x = point.x;
-                let x = PVal { point: i, val: x };
-                xs[xi] = x;
 
-                let y = point.y;
+                for (i, point) in points.iter().enumerate() {
-                let y = PVal { point: i, val: y };
+                    let xi = xpoints[i];
+                    let x = PVal::new(i, point.x);
+                    xs[xi] = x;
+                }
+            });
+
+            s.spawn(|| {
+                let mut ys = self.ys.write().unwrap();
+                let ypoints = self.ypoints.read().unwrap();
+
+                for (i, point) in points.iter().enumerate() {
+                    let yi = ypoints[i];
+                    let y = PVal::new(i, point.y);
                     ys[yi] = y;
                 }
-        }
+            });
+        });
+
         self.sort();
     }
 
@@ -122,9 +137,10 @@ impl Spindex2d {
         let xhandle = thread::spawn(move || {
             let mut xs = xs.write().unwrap();
             xs.sort_unstable();
+            let mut points = points.write().unwrap();
             for (i, x) in xs.iter().enumerate() {
-                let p = x.point;
+                let p = x.point_index;
-                points[p].store(i, Relaxed);
+                points[p] = i;
             }
         });
 
@@ -133,9 +149,10 @@ impl Spindex2d {
         let yhandle = thread::spawn(move || {
             let mut ys = ys.write().unwrap();
             ys.sort_unstable();
+            let mut points = points.write().unwrap();
             for (i, y) in ys.iter().enumerate() {
-                let p = y.point;
+                let p = y.point_index;
-                points[p].store(i, Relaxed);
+                points[p] = i;
             }
         });