nicole
/
pique
1
0
Fork 0
Code Pull Requests Activity

refactoring

This commit is contained in:
Nicole Tietz-Sokolskaya 2024-06-02 11:21:50 -04:00
parent 3bf0f8de74
commit 012a3175bb
18 changed files with 75 additions and 163 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/bin/admin.rs
View File

@ -11,12 +11,7 @@ pub async fn main() -> Result<()> {
let db_url = dotenvy::var("DATABASE_URL")?;
match AdminCli::parse().command {
AdminCommand::CreateUser {
name,
email,
username,
password,
} => {
AdminCommand::CreateUser { name, email, username, password } => {
let password = match password {
Some(p) => p,
None => {
@ -43,12 +38,7 @@ struct AdminCli {
#[derive(Subcommand, Debug)]
pub enum AdminCommand {
CreateUser {
name: String,
email: String,
username: String,
password: Option<String>,
},
CreateUser { name: String, email: String, username: String, password: Option<String> },
ListUsers,
}

4
src/db.rs
View File

@ -26,9 +26,7 @@ pub fn establish_connection(url: &str) -> SqliteConnection {
/// Panics if the connection pool cannot be created.
pub fn build_connection_pool(url: &str) -> Pool<ConnectionManager<SqliteConnection>> {
let manager = ConnectionManager::<SqliteConnection>::new(url);
Pool::builder()
.build(manager)
.expect("Failed to create connection pool.")
Pool::builder().build(manager).expect("Failed to create connection pool.")
}
/// Runs any pending migrations.

13
src/handler.rs
View File

@ -4,24 +4,13 @@ pub mod login;
pub mod projects;
use axum::http::StatusCode;
use axum::response::Response;
pub use login::{login_page, login_submit};
use tracing::error;
pub fn internal_server_error() -> Response {
Response::builder()
.status(StatusCode::INTERNAL_SERVER_ERROR)
.body("Internal Server Error".into())
.unwrap()
}
pub fn internal_error<E>(err: E) -> (StatusCode, String)
where
E: std::error::Error,
{
error!(?err, "internal error");
(
StatusCode::INTERNAL_SERVER_ERROR,
"Internal Server Error".into(),
)
(StatusCode::INTERNAL_SERVER_ERROR, "Internal Server Error".into())
}

6
src/handler/documents.rs
View File

@ -38,7 +38,7 @@ async fn render_documents_page(
projects => projects,
};
Ok(provider.render_resp("documents/list_documents.html", values))
provider.render_resp("documents/list_documents.html", values)
}
pub async fn create_document_page(
@ -59,7 +59,7 @@ pub async fn create_document_page(
user => user,
projects => projects,
};
Ok(provider.render_resp("documents/create_document.html", values))
provider.render_resp("documents/create_document.html", values)
}
#[derive(Debug, Deserialize)]
@ -138,7 +138,7 @@ pub async fn edit_document_page(
projects => projects,
};
Ok(provider.render_resp("documents/edit_document.html", values))
provider.render_resp("documents/edit_document.html", values)
}
#[derive(Debug, Deserialize)]

5
src/handler/home.rs
View File

@ -1,3 +1,4 @@
use axum::http::StatusCode;
use axum::response::Redirect;
use axum_login::AuthSession;
@ -8,7 +9,7 @@ use crate::prelude::*;
pub async fn home_page(
State(provider): State<Provider>,
auth_session: AuthSession<Provider>,
) -> Response {
) -> Result<Response, (StatusCode, String)> {
if let Some(user) = auth_session.user {
let mut db = provider.db_pool.get().unwrap();
let projects: Vec<Project> =
@ -21,6 +22,6 @@ pub async fn home_page(
provider.render_resp("home.html", values)
} else {
Redirect::to("/login").into_response()
Ok(Redirect::to("/login").into_response())
}
}

36
src/handler/login.rs
View File

@ -1,8 +1,9 @@
use axum::http::StatusCode;
use axum::response::Redirect;
use axum::Form;
use axum_login::AuthSession;
use crate::handler::internal_server_error;
use super::internal_error;
use crate::prelude::*;
use crate::session::Credentials;
@ -15,20 +16,20 @@ pub struct LoginTemplate {
pub async fn login_page(
State(provider): State<Provider>,
auth_session: AuthSession<Provider>,
) -> Response {
if auth_session.user.is_some() {
return Redirect::to("/").into_response();
}
) -> Result<Response, (StatusCode, String)> {
if let Some(_user) = auth_session.user {
Ok(Redirect::to("/").into_response())
} else {
render_login_page(&provider, "", "", None)
}
}
fn render_login_page(
provider: &Provider,
username: &str,
password: &str,
error: Option<&'static str>,
) -> Response {
) -> Result<Response, (StatusCode, String)> {
provider.render_resp(
"login.html",
context! {
@ -45,21 +46,12 @@ pub async fn login_submit(
State(provider): State<Provider>,
mut auth_session: AuthSession<Provider>,
Form(creds): Form<Credentials>,
) -> Response {
match auth_session.authenticate(creds).await {
Ok(Some(user)) => {
if let Err(err) = auth_session.login(&user).await {
error!(?err, "error while logging in user");
return internal_server_error();
}
Redirect::to("/").into_response()
}
Ok(None) => render_login_page(&provider, "", "", Some(LOGIN_ERROR_MSG)),
Err(err) => {
error!(?err, "error while authenticating user");
internal_server_error()
}
) -> Result<Response, (StatusCode, String)> {
if let Some(user) = auth_session.authenticate(creds).await.map_err(internal_error)? {
let _ = auth_session.login(&user).await.map_err(internal_error)?;
Ok(Redirect::to("/").into_response())
} else {
render_login_page(&provider, "", "", Some(LOGIN_ERROR_MSG))
}
}

22
src/handler/projects.rs
View File

@ -4,7 +4,6 @@ use axum::Form;
use axum_login::AuthSession;
use super::internal_error;
use crate::handler::internal_server_error;
use crate::models::project_memberships::{self, ProjectRole};
use crate::models::projects::{self, NewProject};
use crate::models::users::User;
@ -14,22 +13,19 @@ use crate::prelude::*;
pub async fn projects_page(
State(provider): State<Provider>,
auth_session: AuthSession<Provider>,
) -> Response {
) -> Result<Response, (StatusCode, String)> {
if let Some(user) = auth_session.user {
render_projects_page(provider, user).await
} else {
Redirect::to("/login").into_response()
Ok(Redirect::to("/login").into_response())
}
}
async fn render_projects_page(provider: Provider, user: User) -> Response {
let mut db = match provider.db_pool.get() {
Ok(db) => db,
Err(err) => {
error!(?err, "failed to get db connection");
return internal_server_error();
}
};
async fn render_projects_page(
provider: Provider,
user: User,
) -> Result<Response, (StatusCode, String)> {
let mut db = provider.db_pool.get().map_err(internal_error)?;
let projects = permissions::query::accessible_projects(&mut db, &user.id).unwrap_or_default();
let values = context! {
@ -43,10 +39,10 @@ async fn render_projects_page(provider: Provider, user: User) -> Response {
pub async fn create_project_page(
State(provider): State<Provider>,
auth_session: AuthSession<Provider>,
) -> Response {
) -> Result<Response, (StatusCode, String)> {
let user = match auth_session.user {
Some(user) => user,
None => return Redirect::to("/login").into_response(),
None => return Ok(Redirect::to("/login").into_response()),
};
let values = context! {

4
src/logging.rs
View File

@ -1,7 +1,5 @@
use tracing_subscriber::EnvFilter;
pub fn setup_logging() {
tracing_subscriber::fmt()
.with_env_filter(EnvFilter::from_default_env())
.init();
tracing_subscriber::fmt().with_env_filter(EnvFilter::from_default_env()).init();
}

14
src/models/documents.rs
View File

@ -45,13 +45,9 @@ pub mod query {
db: &mut SqliteConnection,
new_document: NewDocument,
) -> Result<Document, DbError> {
diesel::insert_into(dsl::documents)
.values(&new_document)
.execute(db)?;
diesel::insert_into(dsl::documents).values(&new_document).execute(db)?;
let document = dsl::documents
.filter(dsl::id.eq(&new_document.id))
.first(db)?;
let document = dsl::documents.filter(dsl::id.eq(&new_document.id)).first(db)?;
Ok(document)
}
@ -75,10 +71,8 @@ pub mod query {
db: &mut SqliteConnection,
document_id: &str,
) -> Result<Option<Document>, DbError> {
let document = dsl::documents
.filter(dsl::id.eq(document_id))
.first::<Document>(db)
.optional()?;
let document =
dsl::documents.filter(dsl::id.eq(document_id)).first::<Document>(db).optional()?;
Ok(document)
}

5
src/models/project_memberships.rs
View File

@ -84,9 +84,8 @@ pub mod query {
role,
};
let membership = diesel::insert_into(pm::project_memberships)
.values(new_membership)
.get_result(db)?;
let membership =
diesel::insert_into(pm::project_memberships).values(new_membership).get_result(db)?;
Ok(membership)
}

17
src/models/projects.rs
View File

@ -28,13 +28,7 @@ pub struct NewProject {
impl NewProject {
pub fn new(creator_id: String, name: String, description: String, key: String) -> Self {
Self {
id: Uuid::now_v7().to_string(),
creator_id,
name,
description,
key,
}
Self { id: Uuid::now_v7().to_string(), creator_id, name, description, key }
}
}
@ -42,9 +36,8 @@ pub mod query {
use super::*;
pub fn for_user(db: &mut SqliteConnection, user_id: String) -> Result<Vec<Project>, DbError> {
let projects = dsl::projects
.filter(dsl::creator_id.eq(user_id.to_string()))
.load::<Project>(db)?;
let projects =
dsl::projects.filter(dsl::creator_id.eq(user_id.to_string())).load::<Project>(db)?;
Ok(projects)
}
@ -54,9 +47,7 @@ pub mod query {
) -> Result<Project, diesel::result::Error> {
use crate::schema::projects::dsl as p;
let project = diesel::insert_into(p::projects)
.values(new_project)
.get_result(db)?;
let project = diesel::insert_into(p::projects).values(new_project).get_result(db)?;
Ok(project)
}

22
src/models/users.rs
View File

@ -3,9 +3,9 @@ use serde::Serialize;
use uuid::Uuid;
use super::DbError;
use crate::db::ValidationError;
use crate::password;
use crate::schema::users::dsl;
use crate::validation::ValidationError;
#[derive(Queryable, Selectable, Debug, Clone, Serialize)]
#[diesel(table_name = crate::schema::users)]
@ -31,13 +31,7 @@ pub struct NewUser {
impl NewUser {
pub fn new(name: String, username: String, email: String, password: String) -> Self {
let password_hash = password::hash(&password);
Self {
id: Uuid::now_v7().to_string(),
name,
username,
email,
password_hash,
}
Self { id: Uuid::now_v7().to_string(), name, username, email, password_hash }
}
pub fn validate(&self) -> Result<(), Vec<ValidationError>> {
@ -82,20 +76,14 @@ impl<'a> Query<'a> {
}
pub fn by_username(&mut self, username: &str) -> Result<User, DbError> {
let user = dsl::users
.filter(dsl::username.eq(username))
.first::<User>(self.db)?;
let user = dsl::users.filter(dsl::username.eq(username)).first::<User>(self.db)?;
Ok(user)
}
pub fn create(&mut self, new_user: NewUser) -> Result<User, DbError> {
let _ = diesel::insert_into(dsl::users)
.values(&new_user)
.execute(self.db)?;
let _ = diesel::insert_into(dsl::users).values(&new_user).execute(self.db)?;
let new_user = dsl::users
.filter(dsl::id.eq(&new_user.id))
.first::<User>(self.db)?;
let new_user = dsl::users.filter(dsl::id.eq(&new_user.id)).first::<User>(self.db)?;
Ok(new_user)
}

8
src/password.rs
View File

@ -9,18 +9,14 @@ pub fn verify(hash: &str, password: &str) -> bool {
Err(_) => return false, // TODO: log an error
};
Argon2::default()
.verify_password(password.as_bytes(), &parsed_hash)
.is_ok()
Argon2::default().verify_password(password.as_bytes(), &parsed_hash).is_ok()
}
/// Hashes the given password.
pub fn hash(password: &str) -> String {
let salt = SaltString::generate(&mut OsRng);
let hash = Argon2::default()
.hash_password(password.as_bytes(), &salt)
.unwrap();
let hash = Argon2::default().hash_password(password.as_bytes(), &salt).unwrap();
hash.to_string()
}

19
src/permissions.rs
View File

@ -49,10 +49,8 @@ pub mod query {
) -> Result<bool, diesel::result::Error> {
use crate::schema::documents::dsl as d;
let document = d::documents
.filter(d::id.eq(document_id))
.first::<Document>(db)
.optional()?;
let document =
d::documents.filter(d::id.eq(document_id)).first::<Document>(db).optional()?;
match document {
Some(doc) => check_user_project(db, user_id, &doc.project_id, permission),
@ -83,9 +81,7 @@ pub mod query {
use crate::schema::projects::dsl as p;
let project_ids = accessible_project_ids(db, user_id)?;
let projects = p::projects
.filter(p::id.eq_any(project_ids))
.load::<Project>(db)?;
let projects = p::projects.filter(p::id.eq_any(project_ids)).load::<Project>(db)?;
Ok(projects)
}
@ -111,10 +107,7 @@ pub mod query {
.select(d::id)
.load::<String>(db)?;
let document_ids = direct_documents
.into_iter()
.chain(project_documents)
.collect();
let document_ids = direct_documents.into_iter().chain(project_documents).collect();
Ok(document_ids)
}
@ -128,9 +121,7 @@ pub mod query {
use crate::schema::documents::dsl as d;
let document_ids = accessible_document_ids(db, user_id)?;
let documents = d::documents
.filter(d::id.eq_any(document_ids))
.load::<Document>(db)?;
let documents = d::documents.filter(d::id.eq_any(document_ids)).load::<Document>(db)?;
Ok(documents)
}

31
src/provider.rs
View File

@ -1,11 +1,12 @@
use std::sync::Arc;
use axum::http::StatusCode;
use diesel::r2d2::{ConnectionManager, Pool};
use diesel::SqliteConnection;
use minijinja_autoreload::AutoReloader;
use thiserror::Error;
use crate::handler::internal_server_error;
use crate::handler::internal_error;
use crate::prelude::*;
pub type ConnectionPool = Pool<ConnectionManager<SqliteConnection>>;
@ -21,14 +22,14 @@ pub struct Provider {
pub enum ProviderError {
#[error("Error while using the connection pool: {0}")]
R2D2Error(#[from] diesel::r2d2::PoolError),
#[error("Error while rendering template: {0}")]
TemplateError(#[from] minijinja::Error),
}
impl Provider {
pub fn new(db: ConnectionPool, template_loader: AutoReloader) -> Provider {
Provider {
db_pool: db,
template_loader: Arc::new(template_loader),
}
Provider { db_pool: db, template_loader: Arc::new(template_loader) }
}
pub fn db_conn(&self) -> Result<PooledConnection, ProviderError> {
@ -36,23 +37,19 @@ impl Provider {
Ok(conn)
}
pub fn render<T: Serialize>(&self, path: &str, data: T) -> anyhow::Result<String> {
// TODO: more graceful handling of the potential errors here; this should not
// use anyhow
pub fn render<T: Serialize>(&self, path: &str, data: T) -> Result<String, ProviderError> {
let env = self.template_loader.acquire_env().unwrap();
let template = env.get_template(path)?;
let rendered = template.render(data)?;
Ok(rendered)
}
pub fn render_resp<T: Serialize>(&self, path: &str, data: T) -> Response {
let rendered = self.render(path, data);
match rendered {
Ok(rendered) => Html(rendered).into_response(),
Err(err) => {
error!(?err, "error while rendering template");
internal_server_error()
}
}
pub fn render_resp<T: Serialize>(
&self,
path: &str,
data: T,
) -> Result<Response, (StatusCode, String)> {
let rendered = self.render(path, data).map_err(internal_error)?;
Ok(Html(rendered).into_response())
}
}

2
src/session.rs
View File

@ -5,7 +5,7 @@ use crate::models::{self, users, DbError};
use crate::password;
use crate::prelude::*;
#[derive(Serialize, Deserialize)]
#[derive(Clone, Serialize, Deserialize)]
pub struct Credentials {
pub username: String,
pub password: String,

11
src/templates.rs
View File

@ -24,13 +24,8 @@ pub fn setup_filters(env: &mut Environment) {
pub fn heroicon_filter(name: String, classes: Option<String>) -> Result<String, Error> {
let class = classes.unwrap_or_else(|| "".to_owned());
let attrs = IconAttrs::default()
.class(&class)
.fill("none")
.stroke_color("currentColor");
let attrs = IconAttrs::default().class(&class).fill("none").stroke_color("currentColor");
free_icons::heroicons(&name, true, attrs).ok_or(Error::new(
ErrorKind::TemplateNotFound,
"cannot find template for requested icon",
))
free_icons::heroicons(&name, true, attrs)
.ok_or(Error::new(ErrorKind::TemplateNotFound, "cannot find template for requested icon"))
}

5
src/validation.rs
View File

@ -8,9 +8,6 @@ pub struct ValidationError {
impl ValidationError {
pub fn on(field: &str, message: &str) -> ValidationError {
ValidationError {
field: field.to_owned(),
message: message.to_owned(),
}
ValidationError { field: field.to_owned(), message: message.to_owned() }
}
}